Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a few missing endpoints and bug fixes #20

Merged
merged 9 commits into from
Mar 19, 2024

Conversation

b00kdev
Copy link
Contributor

@b00kdev b00kdev commented Mar 19, 2024

Thank you for contributing to Maestro! We appreciate your effort and dedication to improving this project. To ensure that your contribution is in line with the project's guidelines and can be reviewed efficiently, please fill out the template below.

Remember to follow our Contributing Guide before submitting your pull request.

Summary

When attempting to use the Rust SDK, I found a few endpoints I needed to use were not implemented. As well, a few endpoints I tried to use failed at runtime due to bad types in the model or invalid endpoint URLs. This PR addresses those things.

Type of Change

Please mark the relevant option(s) for your pull request:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Code refactoring (improving code quality without changing its behavior)
  • Documentation update (adding or updating documentation related to the project)

Checklist

Please ensure that your pull request meets the following criteria:

  • I have read the Contributing Guide
  • My code follows the project's coding style and best practices
  • My code is appropriately commented and includes relevant documentation
  • I have added tests to cover my changes
  • All new and existing tests pass
  • I have updated the documentation, if necessary

NOTE: I do not actually see any tests, so have not added any to my changes.

Testing

No tests were added

Additional Information

I did add a couple of dependencies. I'm not sure if you want to take these or if maybe they should be feature flags on the crate.

@b00kdev b00kdev requested a review from a team as a code owner March 19, 2024 14:02
Copy link
Contributor

@Vardominator Vardominator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

@Vardominator Vardominator merged commit ba2dd0f into maestro-org:main Mar 19, 2024
1 check passed
@Vardominator
Copy link
Contributor

@b00kdev https://github.com/maestro-org/rust-sdk/releases/tag/v1.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants